Skip to content

Fix core dump on degenerate games by returning trivial zero-dimensional profile #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tturocy merged 2 commits into from
Jun 1, 2026
Merged

Fix core dump on degenerate games by returning trivial zero-dimensional profile #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1b1127
Fix core dump on degenerate games by returning trivial zero-dimension…
AndresFerCervell May 24, 2026
5b2c5c1
Fix core dump on 0-dimension games in logit solvers
AndresFerCervell May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/solvers/logit/efglogit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,9 @@ LogitBehaviorSolve(const LogitQREMixedBehaviorProfile &p_start, double p_regret,
double p_firstStep, double p_maxAccel,
MixedBehaviorObserverFunctionType p_observer)
{
if (p_start.size() == 0) {
return {p_start};
}
PathTracer tracer;
tracer.SetMaxDecel(p_maxAccel);
tracer.SetStepsize(p_firstStep);
Expand All @@ -321,7 +324,6 @@ LogitBehaviorSolve(const LogitQREMixedBehaviorProfile &p_start, double p_regret,
if (scale != 0.0) {
p_regret *= scale;
}

const Game game = p_start.GetGame();
Vector<double> x(ProfileToPoint(p_start));
TracingCallbackFunction callback(game, p_observer);
Expand All @@ -347,6 +349,9 @@ LogitBehaviorSolveLambda(const LogitQREMixedBehaviorProfile &p_start,
double p_firstStep, double p_maxAccel,
MixedBehaviorObserverFunctionType p_observer)
{
if (p_start.size() == 0) {
return {p_start};
}
PathTracer tracer;
tracer.SetMaxDecel(p_maxAccel);
tracer.SetStepsize(p_firstStep);
Expand Down Expand Up @@ -380,6 +385,9 @@ LogitBehaviorEstimate(const MixedBehaviorProfile<double> &p_frequencies, double
MixedBehaviorObserverFunctionType p_observer)
{
const LogitQREMixedBehaviorProfile start(p_frequencies.GetGame());
if (start.size() == 0) {
return start;
}
PathTracer tracer;
tracer.SetMaxDecel(p_maxAccel);
tracer.SetStepsize(p_firstStep);
Expand Down
9 changes: 9 additions & 0 deletions src/solvers/logit/nfglogit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,9 @@ LogitStrategySolve(const LogitQREMixedStrategyProfile &p_start, double p_regret,
double p_firstStep, double p_maxAccel,
const MixedStrategyObserverFunctionType &p_observer)
{
if (p_start.size() == 0) {
return {p_start};
}
PathTracer tracer;
tracer.SetMaxDecel(p_maxAccel);
tracer.SetStepsize(p_firstStep);
Expand Down Expand Up @@ -385,6 +388,9 @@ LogitStrategySolveLambda(const LogitQREMixedStrategyProfile &p_start,
double p_firstStep, double p_maxAccel,
const MixedStrategyObserverFunctionType &p_observer)
{
if (p_start.size() == 0) {
return {p_start};
}
PathTracer tracer;
tracer.SetMaxDecel(p_maxAccel);
tracer.SetStepsize(p_firstStep);
Expand Down Expand Up @@ -418,6 +424,9 @@ LogitStrategyEstimate(const MixedStrategyProfile<double> &p_frequencies, double
MixedStrategyObserverFunctionType p_observer)
{
const LogitQREMixedStrategyProfile start(p_frequencies.GetGame());
if (start.size() == 0) {
return start;
}
PathTracer tracer;
tracer.SetMaxDecel(p_maxAccel);
tracer.SetStepsize(p_firstStep);
Expand Down
Loading