Define and enforce a valid-label criterion for game objects (#944)#957
Open
d-kad wants to merge 4 commits into
Open
Define and enforce a valid-label criterion for game objects (#944)#957d-kad wants to merge 4 commits into
d-kad wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
Description of the changes in this PR
This PR defines and enforces a single criterion for valid game-object labels, centrally at the C++ level.
A label is valid if it consists only of printable ASCII characters and spaces, does not begin or end with a space, and does not contain two consecutive spaces. The empty label remains valid. The definition is enforced in one place (
IsValidLabel/CheckLabelingame.h) so that widening it to permit Unicode in 17.0 (#862) is a localised change.CheckLabelis called from all sixSetLabelmethods (outcome, action, infoset, strategy, player, node) and from theGameStrategyRepconstructor.pygambit, the sixSetLabeldeclarations andNewStrategynow map the C++ exception toValueError(except +ValueError); an invalid label raisesValueError.add_strategynow encodes the label as ASCII, consistent with the other accessors; a non-ASCII label fails at the boundary withUnicodeEncodeError.Tests add per-type valid/invalid/non-ASCII coverage (constants in
tests/games.py).