Add --trust-proxy flag for opt-in X-Forwarded-For trust#136
Merged
Conversation
Replace the injectServeDefault() shim that prepended "serve" to os.Args with a pure defaultArgs() function and cobra.SetArgs(), eliminating global state mutation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace implicit echo XFF trust (loopback/link-local/private by default) with an explicit opt-in via --trust-proxy / PKGPROXY_TRUST_PROXY. When unset, ExtractIPDirect() is used and XFF is ignored entirely. Accepted values: none, loopback, private, CIDR, or bare IP (promoted to /32 or /128). Invalid or mixed-with-none entries fail startup with a clear error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Prevents duplicate entries (e.g. 'none,none' or a repeated IP) from triggering a spurious 'cannot be combined' error. Adds test cases for both duplicate 'none' and duplicate IP inputs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.