feat: register Gemini CLI host with dedicated .gemini subdir#2309
Open
fischer33 wants to merge 3 commits into
Open
feat: register Gemini CLI host with dedicated .gemini subdir#2309fischer33 wants to merge 3 commits into
fischer33 wants to merge 3 commits into
Conversation
.serena/, graphify-out/, and shopify-oauth/ are local artifacts (Serena MCP cache, graphify skill output) and an unrelated nested Next.js project. They were showing as untracked noise; ignore them so the working tree stays clean.
Wire the previously-unregistered Gemini CLI HostConfig into the registry. The rescued config reused Codex's .agents hostSubdir, which collides with codex under validateAllConfigs (hostSubdir/globalRoot must be unique). Retarget Gemini to its native .gemini home (matching its GEMINI.md rewrite and Google's Gemini CLI convention) and bump the host-count assertion 10 -> 11.
Generated per-host skill dirs are not committed (matches .agents, .hermes, etc).
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hosts/index.ts(ALL_HOST_CONFIGS) so the skill-doc pipeline generates Gemini-flavored output..gemininamespace (globalRoot,localSkillRoot,hostSubdir) instead of reusing Codex's.agentsoutput dir — the two would otherwise collide on the testedunique hostSubdir/unique globalRootinvariants.CLAUDE.md→GEMINI.md; tool rewrites map Claude tools to Gemini equivalents (Bash→run_shell_command,Read→read_file,Write→write_file,Edit→replace_in_file,Agent→delegate_to_agent,Glob→list_directory,Grep→search_files).test/host-config.test.ts(10 → 11) to keep the suite green..gemini/output dir (matches the pattern for every other host's generated output).Why
.geminiand not.agentshostSubdiris the render output directory (gen-skill-docs.tswrites generatedSKILL.mdthere), and uniqueness is a tested invariant enforced byvalidateAllConfigs(). Codex already owns.agents(its CLI alias is literallyagents), so the shared subdir was a copy-paste leftover, not a deliberate shared workspace. Gemini gets its own.gemini.Test plan
bun test test/host-config.test.ts— host-config suite passes (69 pass / 4 fail; the 4 failures pre-exist on the base branch and are unrelated: opencode env-detection + gbrain golden-file drift; verified via stash baseline).bun run gen:skill-docs— all 47 skills generate for the gemini host with correct path transformations (26.geminirefs, 0.agentsleaks,CLAUDE.md→GEMINI.mdrewrite verified).🤖 Generated with Claude Code