Skip to content

include struct name in _ffi_check_ symbol#79

Merged
gd-0 merged 1 commit into
mainfrom
gd/spine-ffi-check-collision
May 5, 2026
Merged

include struct name in _ffi_check_ symbol#79
gd-0 merged 1 commit into
mainfrom
gd/spine-ffi-check-collision

Conversation

@gd-0
Copy link
Copy Markdown
Contributor

@gd-0 gd-0 commented May 5, 2026

Two #[from_spine] structs in the same module that share a field name generated colliding extern fn names. Make the symbol ffi_check_.


Open in Devin Review

Two #[from_spine] structs in the same module that share a field name
(e.g. tile_info on SenderSpine + DataGatherSpine) generated colliding
extern fn names. Make the symbol _ffi_check_<struct>_<field>.
@gd-0 gd-0 requested a review from a team May 5, 2026 11:36
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@gd-0 gd-0 merged commit 6b95391 into main May 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants