please merge#3
Open
Marzona wants to merge 6 commits into
Open
Conversation
- updated/fixed constants values.
- created a sns_utils.py file with sns related code - created a glacier_utils.py file with glacier helper functions - created modules folder with all the files except glacier.py - started to move all the constants into constants.py
… modules/code re-org, adding docstirngs - moved constants into constants file - removed import * and similar
- updated region lists (removed wrong one, adding others new) - other minor updates
Owner
|
Thanks for the pull request. I'll hold off merging it in until you've had a chance to do some testing, just to make sure the master branch is functional. |
Author
|
ok sounds good
…On Thu, Jul 13, 2017 at 12:07 AM, Gabriel Burca ***@***.***> wrote:
Thanks for the pull request. I'll hold off merging it in until you've had
a chance to do some testing, just to make sure the master branch is
functional.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APnbz7X9xaoNq96jxDxj6j6cSE61qqM5ks5sNVGXgaJpZM4ORnZf>
.
--
Simone Marzona
Linux registered user number: 509183
PGP key ID: 1024D/36F88CC3
Star Trek (2009):
Burly Cadet #1: Hey farmboy. Maybe you can't count. But there are four
of us and one of you.
James T. Kirk: So get some more guys and then it'll be an even fight.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello,
I am sending this pull request for not being too behind with your code base. This is the last of the first set of things I changed providing some code cleanup. I would focus now on testing.