Rewriting fixCryptoApiImports and fixSnackbarMarkup to js to make it OS agnostic#2298
Merged
GCHQDeveloper581 merged 7 commits intogchq:masterfrom Apr 11, 2026
Conversation
….com/BigYellowHammer/CyberChef into feature/makeNpmPostInstallOSAgnostic
Contributor
Author
|
I’m following up on my pull request. I’d appreciate any feedback or guidance on whether there are changes I can make to facilitate its review and consideration for merging |
GCHQDeveloper581
approved these changes
Apr 11, 2026
Contributor
GCHQDeveloper581
left a comment
GCHQDeveloper581
left a comment
There was a problem hiding this comment.
Looks good!
Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewriting fixCryptoApiImports and fixSnackbarMarkup to js to make it OS agnostic
Description
Grunt scripts fixCryptoApiImports and fixSnackbarMarkup rewritten to javascript to make installation independant from shells installed on the OS
Existing Issue
Cyberchef installation relied on OS shell to be present
AI disclosure
No AI tools used.
Test Coverage
Manually tested on windows and linux (ubuntu via wsl).
Also tested docker build