Fix: Add currentAmount aggregation to posts list API for help-request progress#385
Merged
3m1n3nc3 merged 1 commit intoJun 26, 2026
Conversation
|
@Ajibose Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3m1n3nc3
requested changes
Jun 26, 2026
3m1n3nc3
left a comment
3m1n3nc3
left a comment
Contributor
There was a problem hiding this comment.
We had a failing PR that broke our CI, this has been resolved, but merging yours at this state will bring us back where we began. Please sync your fork with the latest updates so we can merge.
… progress Adds helpContributions _sum aggregation via groupBy to the GET /api/posts endpoint so each post includes the total amount raised, and updates the mapper and tests accordingly. Closes geevapp#355
Ajibose
force-pushed
the
fix/355-help-request-progress-aggregation
branch
from
2628649 to
be0e693
Compare
Contributor
Author
it is alright, it's been fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #355
Summary
helpContribution.groupBy(_sum: amount)call to theGET /api/postsendpoint, efficiently aggregating raised amounts for all returned posts in one querycurrentAmount(total raised), defaulting to0when no contributions existmapApiPostToClientPostto explicitly mapcurrentAmountso the clientPostshape is always populatedTest plan
vitest run tests/api/posts.test.ts— all tests pass including the newcurrentAmounttestcurrentAmountfrom the list response