Fix critical logic bug and add error handling for unmatched inputs#7
Open
germanschnyder wants to merge 1 commit intomasterfrom
Open
Fix critical logic bug and add error handling for unmatched inputs#7germanschnyder wants to merge 1 commit intomasterfrom
germanschnyder wants to merge 1 commit intomasterfrom
Conversation
- Fix flux_crs.append() being inside the inner coordinate loop in crstats.py, which produced incorrect flux statistics by appending intermediate cumulative values instead of per-CR totals - Raise ValueError in instruments.py when instrument name is unknown instead of silently returning None - Raise ValueError in helpers.py when file extension has no match instead of logging an error and implicitly returning None https://claude.ai/code/session_01EmypcgPKuQ6fh7kzhCwoWN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crstats.py, which produced incorrect flux statistics by appending
intermediate cumulative values instead of per-CR totals
instead of silently returning None
instead of logging an error and implicitly returning None
https://claude.ai/code/session_01EmypcgPKuQ6fh7kzhCwoWN