refactor: Replace sort usage with slices package#1147
Merged
Conversation
jedevc
force-pushed
the
use-slices-package
branch
from
2874f1b to
26d7697
Compare
Signed-off-by: Justin Chadwell <justin@unikraft.com>
jedevc
force-pushed
the
use-slices-package
branch
from
26d7697 to
42a00e9
Compare
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving towards @fenollp's comment in #695 (comment).
I've started working on getting ordering working, but one of the suggestions there was to split out multiple PRs, one for dropping the use of the
sortpackage.The
sortpackage now just directly usesslices.Sortunder the hood anyways, so it's very easy to migrate.