Repository navigation
test(cli): guard the v2 loader keeping render settings - #1470
Conversation
legacyProjectEditor (#1469) has its own tests; this one loads a v2 project through loadCliProject, so the export cannot drop the keys again behind a green helper test.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Verify loaded settings src/cli/loadCliProject.test.ts |
Adds a test that checks cursor.model3d, cursor.clickSound, and audioGainDb in the loaded document. The test restores stubbed globals. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related issues
- [Bug]: CLI export of a v2 project drops 3D cursor, click effects, webcam and audio-gain settings #1467 — Identifies a v2 CLI export bug that drops the cursor and audio settings checked by this test.
Possibly related PRs
- getopenscreen/openscreen#1468 — Adds the same
loadCliProjectregression test and preserves the settings it checks. - getopenscreen/openscreen#1469 — Changes
loadLegacyProjectto retain editor keys; this test exercises that behavior throughloadCliProject.
Suggested reviewers: beetix
Merge Risk: 
e5376
-
The change adds regression coverage for cursor and audio settings without changing production behavior. No actionable merge-blocking risk is established.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies a CLI loader test that guards preservation of render settings. It is concise and related to the main change. Description check The description includes the summary, related issue, change type, release impact, desktop impact, and testing details. The Screenshots / video section is omitted, but it is not required for this non-v… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description includes the summary, related issue, change type, release impact, desktop impact, and testing details. The Screenshots / video section is omitted, but it is not required for this non-visual CLI test.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Summary
Adds a test that loads a v2 project through
loadCliProjectand checks that render settings the normalizer does not know (cursorModel3d,cursorClickSound,audioGainDb) reach the exported document. The fix itself landed in #1469, andlegacyProjectEditorhas its own tests there. This one fails if the loader goes back tonormalizeProjectEditor(project.editor), which I checked.It replaces #1468, which can no longer be rebase-merged after #1469.
Related issue
Refs #1467
Type of change
Release impact
Desktop impact
Testing
npx vitest --run src/clipasses;npx tsc -p tsconfig.test.json --noEmitpasses.🤖 Generated with Claude Code
Summary by CodeRabbit