Fix build_device next step suggesting unsupported --device-id flag#300
Open
trmquang93 wants to merge 1 commit intogetsentry:mainfrom
Open
Conversation
…etsentry#287) The list_devices tool included deviceId in nextStepParams for build_device, but build_device does not accept a deviceId parameter (it builds generically for the iOS device platform). This caused the CLI to render an invalid suggestion like: xcodebuildmcp device build --device-id "DEVICE_UDID" Remove deviceId from build_device's nextStepParams. The build_run_device and test_device entries correctly retain deviceId since those tools require it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #287
The
list_devicestool includeddeviceIdinnextStepParamsforbuild_device, butbuild_devicedoes not accept adeviceIdparameter -- it builds generically for the iOS device platform without targeting a specific device.This caused the CLI to render an invalid suggestion:
Running this command would fail because
builddoes not recognize--device-id.Changes
deviceIdfrombuild_deviceentry innextStepParamswithinlist_devices.tslist_devices.test.tsbuild_run_deviceandtest_deviceentries correctly retaindeviceIdsince those tools require itTest plan