Expand tilde (~) in config paths like derivedDataPath#301
Open
trmquang93 wants to merge 4 commits intogetsentry:mainfrom
Open
Expand tilde (~) in config paths like derivedDataPath#301trmquang93 wants to merge 4 commits intogetsentry:mainfrom
trmquang93 wants to merge 4 commits intogetsentry:mainfrom
Conversation
…etsentry#287) The list_devices tool included deviceId in nextStepParams for build_device, but build_device does not accept a deviceId parameter (it builds generically for the iOS device platform). This caused the CLI to render an invalid suggestion like: xcodebuildmcp device build --device-id "DEVICE_UDID" Remove deviceId from build_device's nextStepParams. The build_run_device and test_device entries correctly retain deviceId since those tools require it.
Paths containing ~ (e.g. ~/.derivedData) were not expanded, causing a literal ~ directory to be created in the project root. Add tilde expansion in both path resolution functions: - resolvePathFromCwd in build-utils.ts (runtime path resolution) - normalizePathValue in project-config.ts (config YAML loading) This allows shared config files to use ~/... paths that work across team members with different home directories.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
The duplicate resolvePathFromCwd in build-settings.ts was missing tilde expansion. This caused derivedDataPath with ~ to work during builds but fail when resolving app paths from build settings (used by build_run_device and get_device_app_path).
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Move the tilde expansion logic into a shared utils/expand-home.ts module and use it from all four call sites: build-utils.ts, project-config.ts, build-settings.ts, and cli/commands/init.ts. The shared version handles both ~/ and ~\ (Windows) consistently, matching the behavior that was previously only in init.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #283
Paths containing
~(e.g.~/.derivedData) in config were not expanded, causing a literal~directory to be created in the project root instead of resolving to the user's home directory.Changes
Added tilde expansion in two path resolution functions:
resolvePathFromCwdinbuild-utils.ts-- handles runtime path resolution when buildingnormalizePathValueinproject-config.ts-- handles path resolution when loadingconfig.yamlBoth functions now expand
~and~/...to the user's home directory before checking if the path is absolute or resolving relative to cwd.This enables shared config files (committed to the repo) to use
~/...paths that resolve correctly across team members with different home directories, as described in the issue.Test plan
build-utils.test.ts: verifies~/.derivedData/testexpands to$HOME/.derivedData/testin xcodebuild commandproject-config.test.ts: verifies~/.derivedData/myprojectexpands correctly when loaded from YAML config