fix: Harden scaffold and utility edge cases#476
Merged
Conversation
Correct scaffold settings, isolate LLDB command output, and make device lookup asynchronous. Also harden xcuserstate parsing, template extraction, and xcodemake installation. Fixes #459
commit: |
cameroncooke
marked this pull request as ready for review
July 16, 2026 16:19
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f77e1b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the verified correctness, concurrency, and integrity findings reported in #459. iOS scaffolding now emits valid orientation and device-family settings; LLDB drains continue output before later commands and escapes interpolated values; physical-device name lookup no longer blocks the event loop; run-destination parsing works without an active scheme; and template/xcodemake helpers no longer mutate the process-wide working directory.
The xcodemake installer now downloads an exact upstream commit, verifies its SHA-256 digest before writing executable content, and atomically replaces the installed script. Device ID formatting remains synchronous, returning the raw ID until the asynchronously populated name cache is available.
Fixes #459