Skip to content

Change/us2/add new region #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmajere merged 2 commits into from
May 20, 2026
Merged

Change/us2/add new region #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72d74a1
ref(us2): Add new region
dmajere May 20, 2026
01c7afe
tests
dmajere May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libs/getsentry.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@
*/

{
group_order: ['s4s2', 'de', 'us', 'control', 'prod-control', 'snty-tools', 'st'],
group_order: ['s4s2', 'de', 'us', 'us2', 'control', 'prod-control', 'snty-tools', 'st'],
// Empty for now — add future test groups here
test_group_order: [],
// These groupings consist of user facing deployments
pipeline_groups: {
s4s2: ['s4s2'],
de: ['de'],
us: ['us'],
us2: ['us2'],
control: ['control'],
'prod-control': ['prod-control'],
'snty-tools': ['snty-tools'],
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/fixtures/pipedream/single-region-multi-cell.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ local pipedream = import '../../../../libs/pipedream.libsonnet';
local pipedream_config = {
name: 'example',
auto_deploy: true,
exclude_regions: ['us', 's4s2', 'customer-1', 'customer-2', 'customer-4', 'customer-7'],
exclude_regions: ['us', 'us2', 's4s2', 'customer-1', 'customer-2', 'customer-4', 'customer-7'],
};

local cells_for(region) = {
Expand Down
4 changes: 4 additions & 0 deletions test/testdata/goldens/getsentry/groups.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,16 @@
],
"us": [
"us"
],
"us2": [
"us2"
]
},
"group_order": [
"s4s2",
"de",
"us",
"us2",
"control",
"prod-control",
"snty-tools",
Expand Down
61 changes: 58 additions & 3 deletions test/testdata/goldens/pipedream/basic-autodeploy.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,14 @@
"format_version": 10,
"pipelines": {
"deploy-example-st": {
"display_order": 5,
"display_order": 6,
"environment_variables": {
"PIPEDREAM_GROUP_REGIONS": "customer-1,customer-2,customer-4,customer-7"
},
"group": "example",
"materials": {
"deploy-example-us-pipeline-complete": {
"pipeline": "deploy-example-us",
"deploy-example-us2-pipeline-complete": {
"pipeline": "deploy-example-us2",
"stage": "pipeline-complete"
},
"example_repo": {
Expand Down Expand Up @@ -238,5 +238,60 @@
]
}
}
},
"deploy-example-us2.yaml": {
"format_version": 10,
"pipelines": {
"deploy-example-us2": {
"display_order": 5,
"environment_variables": {
"PIPEDREAM_GROUP_REGIONS": "us2"
},
"group": "example",
"materials": {
"deploy-example-us-pipeline-complete": {
"pipeline": "deploy-example-us",
"stage": "pipeline-complete"
},
"example_repo": {
"branch": "master",
"destination": "example",
"git": "git@github.com:getsentry/example.git"
}
},
"stages": [
{
"deploy": {
"jobs": {
"deploy": {
"elastic_profile_id": "example",
"tasks": [
{
"script": "if [ -n \"${PIPEDREAM_GROUP_REGIONS:-}\" ] && [ -n \"${SENTRY_REGION:-}\" ]; then\n case \",${PIPEDREAM_GROUP_REGIONS},\" in\n *\",${SENTRY_REGION},\"*) ;;\n *)\n echo \"Skipping $SENTRY_REGION (not in PIPEDREAM_GROUP_REGIONS=$PIPEDREAM_GROUP_REGIONS)\"\n exit 0\n ;;\n esac\nfi\n./deploy.sh --region=us2"
}
]
}
}
}
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
{
"exec": {
"command": true
}
}
]
}
}
}
}
]
}
}
}
}
56 changes: 53 additions & 3 deletions test/testdata/goldens/pipedream/basic-autodeploy.jsonnet_single-file.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,14 @@
]
},
"deploy-example-st": {
"display_order": 5,
"display_order": 6,
"environment_variables": {
"PIPEDREAM_GROUP_REGIONS": "customer-1,customer-2,customer-4,customer-7"
},
"group": "example",
"materials": {
"deploy-example-us-pipeline-complete": {
"pipeline": "deploy-example-us",
"deploy-example-us2-pipeline-complete": {
"pipeline": "deploy-example-us2",
"stage": "pipeline-complete"
},
"example_repo": {
Expand Down Expand Up @@ -220,6 +220,56 @@
}
}
]
},
"deploy-example-us2": {
"display_order": 5,
"environment_variables": {
"PIPEDREAM_GROUP_REGIONS": "us2"
},
"group": "example",
"materials": {
"deploy-example-us-pipeline-complete": {
"pipeline": "deploy-example-us",
"stage": "pipeline-complete"
},
"example_repo": {
"branch": "master",
"destination": "example",
"git": "git@github.com:getsentry/example.git"
}
},
"stages": [
{
"deploy": {
"jobs": {
"deploy": {
"elastic_profile_id": "example",
"tasks": [
{
"script": "if [ -n \"${PIPEDREAM_GROUP_REGIONS:-}\" ] && [ -n \"${SENTRY_REGION:-}\" ]; then\n case \",${PIPEDREAM_GROUP_REGIONS},\" in\n *\",${SENTRY_REGION},\"*) ;;\n *)\n echo \"Skipping $SENTRY_REGION (not in PIPEDREAM_GROUP_REGIONS=$PIPEDREAM_GROUP_REGIONS)\"\n exit 0\n ;;\n esac\nfi\n./deploy.sh --region=us2"
}
]
}
}
}
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
{
"exec": {
"command": true
}
}
]
}
}
}
}
]
}
}
}
61 changes: 58 additions & 3 deletions test/testdata/goldens/pipedream/basic-manual.jsonnet_output-files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,14 @@
"format_version": 10,
"pipelines": {
"deploy-example-st": {
"display_order": 5,
"display_order": 6,
"environment_variables": {
"PIPEDREAM_GROUP_REGIONS": "customer-1,customer-2,customer-4,customer-7"
},
"group": "example",
"materials": {
"deploy-example-us-pipeline-complete": {
"pipeline": "deploy-example-us",
"deploy-example-us2-pipeline-complete": {
"pipeline": "deploy-example-us2",
"stage": "pipeline-complete"
},
"example_repo": {
Expand Down Expand Up @@ -243,6 +243,61 @@
}
}
},
"deploy-example-us2.yaml": {
"format_version": 10,
"pipelines": {
"deploy-example-us2": {
"display_order": 5,
"environment_variables": {
"PIPEDREAM_GROUP_REGIONS": "us2"
},
"group": "example",
"materials": {
"deploy-example-us-pipeline-complete": {
"pipeline": "deploy-example-us",
"stage": "pipeline-complete"
},
"example_repo": {
"branch": "master",
"destination": "example",
"git": "git@github.com:getsentry/example.git"
}
},
"stages": [
{
"deploy": {
"jobs": {
"deploy": {
"elastic_profile_id": "example",
"tasks": [
{
"script": "if [ -n \"${PIPEDREAM_GROUP_REGIONS:-}\" ] && [ -n \"${SENTRY_REGION:-}\" ]; then\n case \",${PIPEDREAM_GROUP_REGIONS},\" in\n *\",${SENTRY_REGION},\"*) ;;\n *)\n echo \"Skipping $SENTRY_REGION (not in PIPEDREAM_GROUP_REGIONS=$PIPEDREAM_GROUP_REGIONS)\"\n exit 0\n ;;\n esac\nfi\n./deploy.sh --region=us2"
}
]
}
}
}
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
{
"exec": {
"command": true
}
}
]
}
}
}
}
]
}
}
},
"deploy-example.yaml": {
"format_version": 10,
"pipelines": {
Expand Down
56 changes: 53 additions & 3 deletions test/testdata/goldens/pipedream/basic-manual.jsonnet_single-file.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,14 @@
]
},
"deploy-example-st": {
"display_order": 5,
"display_order": 6,
"environment_variables": {
"PIPEDREAM_GROUP_REGIONS": "customer-1,customer-2,customer-4,customer-7"
},
"group": "example",
"materials": {
"deploy-example-us-pipeline-complete": {
"pipeline": "deploy-example-us",
"deploy-example-us2-pipeline-complete": {
"pipeline": "deploy-example-us2",
"stage": "pipeline-complete"
},
"example_repo": {
Expand Down Expand Up @@ -257,6 +257,56 @@
}
}
]
},
"deploy-example-us2": {
"display_order": 5,
"environment_variables": {
"PIPEDREAM_GROUP_REGIONS": "us2"
},
"group": "example",
"materials": {
"deploy-example-us-pipeline-complete": {
"pipeline": "deploy-example-us",
"stage": "pipeline-complete"
},
"example_repo": {
"branch": "master",
"destination": "example",
"git": "git@github.com:getsentry/example.git"
}
},
"stages": [
{
"deploy": {
"jobs": {
"deploy": {
"elastic_profile_id": "example",
"tasks": [
{
"script": "if [ -n \"${PIPEDREAM_GROUP_REGIONS:-}\" ] && [ -n \"${SENTRY_REGION:-}\" ]; then\n case \",${PIPEDREAM_GROUP_REGIONS},\" in\n *\",${SENTRY_REGION},\"*) ;;\n *)\n echo \"Skipping $SENTRY_REGION (not in PIPEDREAM_GROUP_REGIONS=$PIPEDREAM_GROUP_REGIONS)\"\n exit 0\n ;;\n esac\nfi\n./deploy.sh --region=us2"
}
]
}
}
}
},
{
"pipeline-complete": {
"fetch_materials": false,
"jobs": {
"pipeline-complete": {
"tasks": [
{
"exec": {
"command": true
}
}
]
}
}
}
}
]
}
}
}
Loading
Loading