Repository navigation
fix(service): Start resumable upload expiry at commit - #731
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
+ Coverage 91.91% 92.04% +0.13%
==========================================
Files 117 117
Lines 24141 24420 +279
==========================================
+ Hits 22189 22478 +289
+ Misses 1952 1942 -10
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sentry-junior
Bot
force-pushed
the
junior/fs-564-resumable-commit-expiry
branch
from
October 23, 2026 09:06
86b6587 to
085c0db
Compare
The long-term blob of a resumable upload keeps the deadline resolved at session creation. When the final chunk lands, the blob's deadline is moved to the commit time plus the policy's duration before the HV tombstone is written with the confirmed deadline. The blob may already be past its initial deadline at that point, so ExpiryUpdate gains an explicit include_expired flag that the long-term backends with resumable uploads (GCS, local-fs, in-memory) honor. Other backends and the public tiered set_expiry reject it as unsupported. The session token now carries the required ExpirationPolicy, so tokens issued before this change fail to decode instead of committing without an expiry. Fixes FS-564 Co-Authored-By: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
junior/fs-564-resumable-commit-expiry
branch
from
October 23, 2026 09:49
e608df4 to
f43e791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A resumable upload's deadline was fixed at session creation, so a short TTL could expire before the upload committed.
Now, for an upload starting at
T, completing atT + D, with TTLL:T + L, as before. The token carries theExpirationPolicyinstead of the deadline.set_expiry(At(now + L))moves the blob toT + D + L. The tombstone uses the confirmed deadline. If LT doesn't confirm, no tombstone is written.ExpiryUpdate::include_expired: this is a new parameter that lets that call update a blob that's already logically expired, i.e. pastT + L. Only GCS, local-fs and in-memory LT honor it. The publicset_expiryand the other backends returnUnsupported.Notes:
expiration_policyand are rejected, so sessions open at deploy time must restart.T + Lpassed by more than about a day before commit, there is a tiny chance that GCS runs exactly after the commit and the object is already physically gone when we attempt to bump its expiry. In that case, we fail the commit.Closes FS-564
via @lcian.
--
View Junior Session [Sentry]