feat(upload): Remove feature flag for endpoint#6171
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c9b94d1. Configure here.
| /// Enable the experimental Trace Attachment pipeline in Relay. | ||
| #[serde(rename = "projects:trace-attachment-processing")] | ||
| TraceAttachmentProcessing, | ||
| /// Enable the upload endpoint for attachments. |
There was a problem hiding this comment.
Missing graduated upload flag
Medium Severity
Removing UploadEndpoint without following the usual graduation pattern leaves downstream relays without projects:relay-upload-endpoint. Upgraded relays drop that string as an unknown feature during deserialization, and ProjectConfig::sanitize no longer injects it, so older hops that still call require_feature can reject uploads even when Sentry still sends the flag.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c9b94d1. Configure here.
| /// Enable the experimental Trace Attachment pipeline in Relay. | ||
| #[serde(rename = "projects:trace-attachment-processing")] | ||
| TraceAttachmentProcessing, | ||
| /// Enable the upload endpoint for attachments. |
2 participants
Enable the upload endpoint for everyone. In case of an incident we can still disable it through the
relay.endpoint-fetch-config.enabledkillswitch.ref: INGEST-982