Skip to content

chore: Auto-request mobile team review on public API changes#8303

Merged
antonis merged 2 commits into
mainfrom
chore/codeowners-mobile-api-review
Jul 1, 2026
Merged

chore: Auto-request mobile team review on public API changes#8303
antonis merged 2 commits into
mainfrom
chore/codeowners-mobile-api-review

Conversation

@antonis

@antonis antonis commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

📜 Description

Adds a CODEOWNERS rule for the committed swift-api-digester snapshots at the repo root (sdk_api*.json)

💡 Motivation and Context

Public API changes in the mobile SDKs should be reviewed by another mobile SDK team member for cross-SDK consistency.

💚 How did you test it?

Manually

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • If I added a new public API, I also added it to the SentryObjC wrapper.

Add a CODEOWNERS rule for the committed swift-api-digester snapshots
(sdk_api*.json). They only change when the public API changes, so
@getsentry/team-mobile is now auto-requested as a reviewer on API changes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

@philprime philprime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime added the ready-to-merge Use this label to trigger all PR workflows label Jun 30, 2026
Per review feedback, list the existing global owners on the API snapshot
rule as well, so they remain code owners of the files and the mobile team
is added rather than replacing them.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Comment thread .github/CODEOWNERS
@antonis antonis merged commit a3eae5a into main Jul 1, 2026
188 of 189 checks passed
@antonis antonis deleted the chore/codeowners-mobile-api-review branch July 1, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants