Skip to content

feat: Add queue name, description, and op models#446

Merged
cleptric merged 5 commits into
mainfrom
cleptric/feat/add-queue-models
Jun 30, 2026
Merged

feat: Add queue name, description, and op models#446
cleptric merged 5 commits into
mainfrom
cleptric/feat/add-queue-models

Conversation

@cleptric

Copy link
Copy Markdown
Member

Add convention models for queue operations (queue, queue.publish, queue.create, queue.receive, queue.process, queue.settle). Name and description inference use messaging.destination.name, with a static "Queue" fallback for names.

Name model (model/name/queue.json)

Infers span names from messaging.destination.name, falling back to "Queue".

Description model (model/description/queue.json)

Infers span descriptions from messaging.destination.name.

Op model (model/op/queue.json)

Defines the six queue span operations with descriptions. Generated JS and Rust constants are included.

Add inference models for queue operations (queue, queue.publish,
queue.create, queue.receive, queue.process, queue.settle) with
name and description inference based on messaging.destination.name.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (description) Add cache and resource description models by cleptric in #444
  • (name) Add resource span name model by cleptric in #445
  • Add queue name, description, and op models by cleptric in #446
  • Add name and description models for browser and url.template for HTTP server by cleptric in #448

🤖 This preview updates automatically when you update the PR.

@cleptric cleptric marked this pull request as ready for review June 22, 2026 13:09
@cleptric cleptric requested review from a team, Lms24, mjq and nsdeschenes as code owners June 22, 2026 13:09
Comment thread model/name/queue.json Outdated
cleptric and others added 2 commits June 22, 2026 15:42
Remove the dedicated queue name model since messaging.json already
covers queue ops. Rename op and description files from queue to
messaging to align with the existing name model.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Regenerate TypeScript and Rust op constants to reflect the queue
to messaging model rename. Constants are now prefixed with MESSAGING_
instead of QUEUE_.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment thread model/description/messaging.json
@cleptric cleptric enabled auto-merge (squash) June 30, 2026 17:11

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d1c3f36. Configure here.

Comment thread model/op/messaging.json
},
{
"name": "queue.settle",
"description": "Settling a message, e.g. acknowledging or rejecting it."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queue ops lack name model

Medium Severity

This change registers queue.publish, queue.create, queue.receive, queue.process, and queue.settle in the op and description models, but model/name/messaging.json still omits those ops. Span name inference only applies to ops listed in name conventions, so spans using the new queue operations will not get the intended messaging.destination.name / Queue naming described in the PR.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d1c3f36. Configure here.

@cleptric cleptric merged commit 8882237 into main Jun 30, 2026
17 checks passed
@cleptric cleptric deleted the cleptric/feat/add-queue-models branch June 30, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants