feat(attributes): Add url.same_origin (deprecated) and http.request.same_origin (replacement) attributes#456
feat(attributes): Add url.same_origin (deprecated) and http.request.same_origin (replacement) attributes#456Lms24 wants to merge 1 commit into
url.same_origin (deprecated) and http.request.same_origin (replacement) attributes#456Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
🤖 This preview updates automatically when you update the PR. |
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Semantically I'm not sure this is a property of the URL, rather than e.g. the request as a whole - I'd consider http.request.same_origin personally - but my LOGAF is low and it looks like this is an attribute we're already sending so probably not worth changing now 👍
yes, it's already being sent. I'm happy to deprecate this one and migrate to the request one in the next SDK major. Fully agree that scoping this information to the request is more correct. Thanks for raising! UPDATE: Adjusted the PR to include both attributes and deprecate the url one |
…ame_origin` Add `http.request.same_origin` as the canonical attribute and deprecate `url.same_origin` in its favor. Both attributes carry cross-aliases and the deprecated one points to the replacement via `deprecation.replacement`. Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24
force-pushed
the
lms/feat-attr-add-url.same_origin
branch
from
4a87027 to
28af264
Compare
Lms24
changed the title
url.same_origin attributeurl.same_origin (deprecated) and http.request.same_origin (replacement) attributes
2 participants
Adds two attributes:
url.same_origin: Sent today by the browser SDK, indicating that the url is made to the same origin the page is currently on. While valuable information, theurlnamespace doesn't fit this information, since it's a property of the request, not the url itself (h/t @mjq for pointing this out). Therefore this attribute will be marked as deprecated.http.request.same_origin: Therefore replacesurl.same_origin, which we'll also start using in the SDK in v11.