fix(build/js): Add subpath export shims for legacy bundlers#459
Merged
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
andreiborza
approved these changes
Jul 1, 2026
mydea
approved these changes
Jul 1, 2026
cleptric
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, adding
@sentry/conventionsto code bases using legacy tooling (old TS versions or, as we found out, webpack 4), results in build failures. These old tools don't support theexportsconditions field or the subpath exports inside of them. Therefore, they'd resolve an@sentry/conventions/attributesimport to the file@sentry/coventions/attributes.jsrather than the entry point declared inexports.This PR adds the shim file so that the import resolves to the shim file, which in turn re-exports from the corresponding subpath export entry point file. We're pointing to CJS on purpose here, given the age of said legacy tools.
Why do we care? We need this for using the conventions package in our JS SDKs. We have a webpack 4 e2e test to ensure our SDK packages stay compatible with legacy setups, which failed after adding and importing from the current sentry conventions package. (getsentry/sentry-javascript#21855)