ref(ds): Specify how the DSC is interpreted in Relay#17899
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Dav1dde
force-pushed
the
dav1d/ds-dsc-rewrite
branch
from
5545fae to
84baf8c
Compare
shellmayr
reviewed
May 27, 2026
Member
There was a problem hiding this comment.
I'm not sure what "Requires DSC" meas in this case, can we be more specific what the condition here is?
Member
Author
There was a problem hiding this comment.
Payload requires DSC, is that better? 🤔
loewenheim
requested changes
May 27, 2026
loewenheim
approved these changes
May 27, 2026
shellmayr
reviewed
May 27, 2026
jjbayer
reviewed
Jun 2, 2026
|
|
||
| A dynamic sampling context which originates from either the same project or a project within the same organization is considered valid and Relay will apply the sampling rules from the root project as described in the previous section. | ||
|
|
||
| DSCs originating in different organizations or unknown projects are discarded and Relay will re-compute a DSC based on the data of the payload and scoped to the current project. The computed dynamic sampling context is then used to apply the dynamic sampling rules. |
Member
There was a problem hiding this comment.
Is this the only case where we generate a DSC from the payload? Or do we also do it if the DSC is missing but not required?
Member
Author
There was a problem hiding this comment.
Should be the only case, no DSC ends up at 100% SR
Co-authored-by: Simon Hellmayr <shellmayr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Adds more information how the DSC is interpreted and applied in Relay.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: