Skip to content

feat(metrics): [Trace Metrics 16] Only send user attributes if sendDefaultPii is true #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adinauer merged 1 commit into from
Jan 14, 2026
Merged

feat(metrics): [Trace Metrics 16] Only send user attributes if sendDefaultPii is true #4995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sentry/src/main/java/io/sentry/metrics/MetricsApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,9 @@ private void captureMetrics(
setServerName(attributes);
}

setUser(attributes);
if (scopes.getOptions().isSendDefaultPii()) {
setUser(attributes);

@markushi markushi Jan 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least on Android [we always seem to at least set the installation id] when no user is manually set, (

sentry-java/sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java

Lines 168 to 173 in 3258517

if (user.getId() == null) {
user.setId(options.getRuntimeManager().runWithRelaxedPolicy(() -> Installation.id(context)));
}
if (user.getIpAddress() == null && options.isSendDefaultPii()) {
user.setIpAddress(IpAddressUtils.DEFAULT_IP_ADDRESS);
}
), regardless of sendDefaultPii.
Doesn't need to be addressed here, but maybe worth talking about (also affects logs).

@adinauer adinauer Jan 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #5018 so we can track it separately and unblock this PR.

}
Comment thread
adinauer marked this conversation as resolved.

return attributes;
}
Expand Down
Loading