Skip to content

test: Webpack integration tests#904

Merged
timfish merged 3 commits intomainfrom
timfish/test/webpack
Mar 30, 2026
Merged

test: Webpack integration tests#904
timfish merged 3 commits intomainfrom
timfish/test/webpack

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Mar 29, 2026

This PR follows #899 and the previous PRs by adding webpack tests

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Use crypto.randomUUID rather than uuid by timfish in #892

Internal Changes 🔧

  • Webpack integration tests by timfish in #904
  • Isolate integration test package installs by timfish in #902
  • Pin GitHub Actions to full-length commit SHAs by joshuarli in #900
  • Rollup integration tests by timfish in #897
  • New integration tests by timfish in #896
  • Remove lerna by timfish in #895
  • Migrate to Vitest by timfish in #894

🤖 This preview updates automatically when you update the PR.

@timfish timfish changed the title tet: Webpack integration tests test: Webpack integration tests Mar 29, 2026
@timfish timfish marked this pull request as ready for review March 29, 2026 12:26
@timfish timfish requested a review from chargome March 29, 2026 12:26
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@timfish timfish enabled auto-merge (squash) March 29, 2026 20:58
Comment on lines +7 to +10
"webpack": "5.105.4",
"webpack-cli": "6.0.1",
"@babel/preset-react": "7.23.3",
"@sentry/webpack-plugin": "5.1.1"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Are we testing on pinned versions intentionally?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes mainly because we're snapshotting the output. Don't really want all the tests failing when any bundler changes their output. Probably less of an issue with webpack as it doesn't change mutch.

@timfish timfish merged commit 0694741 into main Mar 30, 2026
54 of 56 checks passed
@timfish timfish deleted the timfish/test/webpack branch March 30, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants