Skip to content

fix(aws-serverless): guard against negative timeout warning delay #19932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
james-suvera wants to merge 2 commits into from
Closed

fix(aws-serverless): guard against negative timeout warning delay #19932

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
973ad2b
fix(aws-serverless): guard against negative timeout warning delay
james-suvera Mar 23, 2026
0e16bfb
test(aws-serverless): add test for negative timeout warning delay guard
james-suvera Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/aws-serverless/src/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ function setupTimeoutWarning(context: Context, options: WrapperOptions): NodeJS.
if (options.captureTimeoutWarning) {
const timeoutWarningDelay = tryGetRemainingTimeInMillis(context) - options.timeoutWarningLimit;

if (timeoutWarningDelay < 1) {
return undefined;
}
Comment thread
james-suvera marked this conversation as resolved.

return setTimeout(() => {
withScope(scope => {
scope.setTag('timeout', humanReadableTimeout);
Expand Down
Loading