ref(aws-serverless): Vendor aws-sdk instrumentation#20988
Conversation
Closes #20514 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
size-limit report 📦
|
Previously a transitive dependency of @opentelemetry/instrumentation-aws-sdk, now needed directly by the vendored code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| }, | ||
| "dependencies": { | ||
| "@opentelemetry/api": "^1.9.1", | ||
| "@opentelemetry/core": "^2.6.1", |
There was a problem hiding this comment.
New dependency @opentelemetry/core added as bundle-increasing change
Low Severity
A new direct dependency @opentelemetry/core (^2.6.1) was added to package.json. Previously this package was only a transitive dependency pulled in by @opentelemetry/instrumentation-aws-sdk. Now that the instrumentation is vendored, @opentelemetry/core is explicitly required because the vendored code imports hrTime, suppressTracing, hrTimeDuration, and hrTimeToMilliseconds from it. This may increase the bundle size for the aws-serverless package. Flagging per the rule about large bundle size increases — this is likely unavoidable but worth noting.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit d98ceae. Configure here.
There was a problem hiding this comment.
the size check seems to disagree
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ffc25e2. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
@nicohrubec does this close #19237 ? |
|
@aldenquimby it does not |
2 participants
Vendors
@opentelemetry/instrumentation-aws-sdkinto the SDK with no logic changes.TokenUsageandConverseStreamOutputtypes from@aws-sdk/client-bedrock-runtimeare inlined as simplified interfaces to avoid requiring the package as a dependency.Closes #20514