feat(replays): Record segment names that occur during replay#21851
Merged
Conversation
Contributor
size-limit report 📦
|
mjq
requested review from
Lms24,
logaretm and
mydea
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8f45b63. Configure here.
logaretm
reviewed
Jul 2, 2026
logaretm
left a comment
logaretm
left a comment
Member
There was a problem hiding this comment.
Got some m/q comments in there. Also would be great to lock down the static spans (non-streaming) by asserting segmentNames in handleAfterSendEvent.test.ts. The afterSendEvent transaction path is writing names untested as far as I can tell.
Member
Author
|
@logaretm Thanks very much! I removed the coupling and added the missing test cases, if you wouldn't mind giving it another look. |
logaretm
approved these changes
Jul 7, 2026
49 tasks
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record a new
segment_namesfield on replay events.This will be used in the product on the Transaction Summary page to fetch replays related to a particular named transaction.
This sidesteps our current issue under span streaming where Replay's
buffermode leads tosentry.replay.idattributes often pointing to missing Replays, which broke the assumption that a "query spans by segment name to get replay IDs, then query replays with those IDs" query flow will return a usable number of results.Closes REPLAY-937.