Skip to content

feat(server-utils): Migrate @opentelemetry/instrumentation-graphql to orchestrion#21885

Draft
chargome wants to merge 1 commit into
developfrom
cg/orchestrion-graphql
Draft

feat(server-utils): Migrate @opentelemetry/instrumentation-graphql to orchestrion#21885
chargome wants to merge 1 commit into
developfrom
cg/orchestrion-graphql

Conversation

@chargome

@chargome chargome commented Jul 1, 2026

Copy link
Copy Markdown
Member

closes #20752

@chargome chargome self-assigned this Jul 1, 2026
@chargome

chargome commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

bugbot run

Comment thread packages/node/src/sdk/experimentalUseDiagnosticsChannelInjection.ts Outdated
Comment thread packages/server-utils/src/integrations/tracing-channel/graphql/spans.ts Outdated
Comment thread packages/node/src/integrations/tracing/index.ts
@chargome

chargome commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@chargome

chargome commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

bugbot run

Comment thread packages/server-utils/src/integrations/tracing-channel/graphql/constants.ts Outdated
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 27.59 kB - -
@sentry/browser - with treeshaking flags 26.03 kB - -
@sentry/browser (incl. Tracing) 46.24 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.01 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.01 kB - -
@sentry/browser (incl. Tracing, Replay) 85.49 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.1 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 90.19 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 102.84 kB - -
@sentry/browser (incl. Feedback) 44.76 kB - -
@sentry/browser (incl. sendFeedback) 32.38 kB - -
@sentry/browser (incl. FeedbackAsync) 37.51 kB - -
@sentry/browser (incl. Metrics) 28.67 kB - -
@sentry/browser (incl. Logs) 28.91 kB - -
@sentry/browser (incl. Metrics & Logs) 29.59 kB - -
@sentry/react 29.38 kB - -
@sentry/react (incl. Tracing) 48.51 kB - -
@sentry/vue 33.03 kB - -
@sentry/vue (incl. Tracing) 48.11 kB - -
@sentry/svelte 27.61 kB - -
CDN Bundle 30 kB - -
CDN Bundle (incl. Tracing) 48.24 kB - -
CDN Bundle (incl. Logs, Metrics) 31.57 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.54 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 70.77 kB - -
CDN Bundle (incl. Tracing, Replay) 85.7 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 87 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.49 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.78 kB - -
CDN Bundle - uncompressed 89.35 kB - -
CDN Bundle (incl. Tracing) - uncompressed 145.96 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 94.05 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 149.93 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 218.59 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 264.97 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 268.93 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 278.68 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 282.62 kB - -
@sentry/nextjs (client) 50.95 kB - -
@sentry/sveltekit (client) 46.65 kB - -
@sentry/core/server 78.38 kB - -
@sentry/core/browser 64.73 kB - -
@sentry/node-core 63.2 kB +0.01% +1 B 🔺
@sentry/node 123.2 kB +0.01% +2 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 69.95 kB - -
@sentry/node/light 50.72 kB +0.01% +2 B 🔺
@sentry/node - without tracing 74.24 kB +0.01% +1 B 🔺
@sentry/aws-serverless 85.02 kB +0.01% +1 B 🔺
@sentry/cloudflare (withSentry) - minified 181.56 kB - -
@sentry/cloudflare (withSentry) 449.18 kB - -

View base workflow run

@chargome

chargome commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@chargome

chargome commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 43d4510. Configure here.

import { setDiagnosticsChannelInjectionLoader } from './diagnosticsChannelInjection';

/** Per-integration options for the diagnostics-channel integrations swapped in by injection. */
export interface DiagnosticsChannelInjectionOptions {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is still in debate

…to orchestrion

Rewrite the graphql integration as a diagnostics-channel subscriber, with orchestrion
injecting channels into graphql's compiled `parse`/`validate`/`execute` (v14–v16). Registers
`graphqlIntegration` in the channelIntegrations registry and adds a per-lib config file, so the
opt-in and `diagnosticsChannelInjectionIntegrations()` pick it up automatically. Span
names/attributes/origin mirror the OTel integration (distinct `auto.graphql.orchestrion.graphql`
origin); the structural graphql types are shared with the vendored OTel instrumentation.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@chargome chargome force-pushed the cg/orchestrion-graphql branch from 0eccdf9 to d2c7ce0 Compare July 6, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite @opentelemetry/instrumentation-graphql to orchestrion

1 participant