ref(node): Use @sentry/conventions and vendor remaining semantic conventions#21893
Merged
Conversation
…nventions Source span attribute keys in `@sentry/node` from `@sentry/conventions/attributes` instead of `@opentelemetry/semantic-conventions` and the locally vendored `./semconv` constants, for attributes that have a `@sentry/conventions` equivalent. Keys without an equivalent and all value constants stay vendored locally. The package source no longer imports `@opentelemetry/semantic-conventions`, and the dependency is removed. No functional change: all string values are identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
requested review from
JPeer264 and
mydea
and removed request for
a team
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source span attribute keys in
@sentry/nodefrom@sentry/conventions/attributesinstead of@opentelemetry/semantic-conventionsand the locally vendored./semconvconstants, for every attribute that has a@sentry/conventionsequivalent. The package source no longer imports@opentelemetry/semantic-conventions, and the dependency is dropped frompackage.json.This revives and rebases the closed #21635 onto current
develop, mirroring the mergedref(aws-serverless): Use @sentry/conventions(#21597) and the other conventions migrations.No functional change: all string values are identical.
Details
@sentry/conventions/attributesacross connect, koa, hapi, hono, fastify (v3), firebase/firestore, postgresjs, and the vendored redis/ioredis, mongo, mongoose, mysql, mysql2, postgres, knex, kafka, amqplib, and tedious instrumentations.db.response.status_code,db.connection_string,db.mongodb.collection,db.sql.table, kafka/rabbitmq-specific messaging keys, and all*_VALUE_*constants.hapi/vendored/semconv.tsbecame empty and was deleted.db.system,db.name,db.operation,db.statement,http.method,net.peer.*,net.transport) carry atypescript/no-deprecateddisable, matching the existing knex/postgres vendored files.