test(e2e/nitro-3): Pin rolldown to 1.1.3 to fix build#21894
Closed
nicohrubec wants to merge 1 commit into
Closed
Conversation
nicohrubec
changed the title
`rolldown@1.1.4` (published 2026-07-01) tightened CJS→ESM named-export interop,
so nitro's `import { nodeFileTrace }` from the CommonJS `@vercel/nft` fails at
build time. The app tracked `rolldown: latest` with no lockfile, so fresh installs
picked it up. Pin to the last-good `1.1.3` (verified locally: 1.1.4 fails, 1.1.3 builds).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
nh/fix-nitro3-e2e-nft
branch
from
a051545 to
77ff58d
Compare
nicohrubec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
E2E nitro-3 Testjob fails at the Build E2E app step with:Trigger:
rolldown@1.1.4, published 2026-07-01 (the failing run hasrolldown@1.1.4in its stack). It tightened CJS→ESM named-export interop, so nitro'simport { nodeFileTrace }from the CommonJS@vercel/nftno longer resolves at build time. The nitro-3 app trackedrolldown: latestwith no committed lockfile, so a fresh CI install grabbed 1.1.4 hours after publish.nitro(3 weeks old, resolves to the exact pinned beta) and@vercel/nft(5+ weeks) did not move.Pins
rolldownto the last-good1.1.3. Verified locally:pnpm buildfails on1.1.4, succeeds on1.1.3(✓ built). Scoped to nitro-3 — the only app that pinsrolldowndirectly and the only E2E job that failed.Unrelated to any SDK change; unblocks the E2E gate for all open PRs. Cleanup debt: revert to
latestonce rolldown restores the interop (or nitro/@vercel/nft adapt).🤖 Generated with Claude Code