Skip to content

test(browser): Fix web worker route-registration race in debug ID test #21920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 3 commits into from
Jul 6, 2026
+25 −16
Merged

test(browser): Fix web worker route-registration race in debug ID test #21920

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d86ba2
test(browser): Fix web worker route-registration race in debug ID test
Lms24 Jul 2, 2026
3a7114c
fix another flake
Lms24 Jul 6, 2026
752b0c5
deslop comments
Lms24 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 25 additions & 16 deletions dev-packages/browser-integration-tests/suites/integrations/webWorker/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/core';
import { sentryTest } from '../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest } from '../../../utils/helpers';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';

sentryTest('Assigns web worker debug IDs when using webWorkerIntegration', async ({ getLocalTestUrl, page }) => {
const bundle = process.env.PW_BUNDLE;
Expand All @@ -11,18 +11,23 @@ sentryTest('Assigns web worker debug IDs when using webWorkerIntegration', async

const url = await getLocalTestUrl({ testDir: __dirname });

const errorEventPromise = getFirstSentryEnvelopeRequest<Event>(page, url);

page.route('**/worker.js', route => {
route.fulfill({
// `init.js` creates the worker at page load, so the route must be registered before navigating.
await page.route('**/worker.js', route => {
return route.fulfill({
path: `${__dirname}/assets/worker.js`,
});
});

const button = page.locator('#errWorker');
await button.click();
const errorEventPromise = waitForErrorRequest(
page,
event => !!event.exception?.values?.[0]?.value?.includes('Worker error for testing'),
);

await page.goto(url);

await page.locator('#errWorker').click();

const errorEvent = await errorEventPromise;
const errorEvent = envelopeRequestParser<Event>(await errorEventPromise);

expect(errorEvent.debug_meta?.images).toBeDefined();

Expand All @@ -45,20 +50,24 @@ sentryTest('Captures unhandled rejections from web workers', async ({ getLocalTe

const url = await getLocalTestUrl({ testDir: __dirname });

const errorEventPromise = getFirstSentryEnvelopeRequest<Event>(page, url);

page.route('**/worker.js', route => {
route.fulfill({
// `init.js` creates the worker at page load, so the route must be registered before navigating.
await page.route('**/worker.js', route => {
return route.fulfill({
path: `${__dirname}/assets/worker.js`,
});
});

const button = page.locator('#rejectionWorker');
await button.click();
const errorEventPromise = waitForErrorRequest(
page,
event => !!event.exception?.values?.[0]?.value?.includes('Worker unhandled rejection'),
);

await page.goto(url);

await page.locator('#rejectionWorker').click();

const errorEvent = await errorEventPromise;
const errorEvent = envelopeRequestParser<Event>(await errorEventPromise);

// Verify the unhandled rejection was captured
expect(errorEvent.exception?.values?.[0]?.value).toContain('Worker unhandled rejection');
expect(errorEvent.exception?.values?.[0]?.mechanism?.type).toBe('auto.browser.web_worker.onunhandledrejection');
expect(errorEvent.exception?.values?.[0]?.mechanism?.handled).toBe(false);
Expand Down
Loading