test(node): Refactor remaining express integrations tests to new runner#21949
Open
mydea wants to merge 2 commits into
Open
test(node): Refactor remaining express integrations tests to new runner#21949mydea wants to merge 2 commits into
mydea wants to merge 2 commits into
Conversation
Contributor
size-limit report 📦
|
mydea
requested review from
JPeer264 and
andreiborza
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates the remaining node integration tests for express to the new runner format (so they also auto-run for orchestrion etc). I opted to run them cjs only to keep things faster, this should be fine for now imho.
Tests have been collapsed how it makes sense. Test logic itself should not have changed.