feat(browser): Set url.path and url.full on pageload and navigation spans#21952
Open
Lms24 wants to merge 6 commits into
Open
feat(browser): Set url.path and url.full on pageload and navigation spans#21952Lms24 wants to merge 6 commits into
Lms24 wants to merge 6 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
2 times, most recently
from
088a93e to
7c4bfcb
Compare
logaretm
approved these changes
Jul 3, 2026
Member
Author
Yes, we can now use conventions instead of hard-coded strings or the exports from |
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
d20b04f to
c20fc4a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c20fc4a. Configure here.
| [SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1, | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'custom', | ||
| [URL_FULL]: 'https://example.com/', | ||
| [URL_PATH]: '/', |
There was a problem hiding this comment.
Hook test missing url option
Low Severity
startBrowserTracingNavigationSpan now emits beforeStartNavigationSpan with { isRedirect, url }, but the listener test still expects only { isRedirect: undefined }. The assertion no longer matches the hook payload and the test should fail until it includes the url field.
Reviewed by Cursor Bugbot for commit c20fc4a. Configure here.
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
c20fc4a to
41cc9bd
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
41cc9bd to
3831498
Compare
…pans Set the `url.path` (raw, unparameterized pathname without query, fragment or domain) and `url.full` (the entire URL) attributes on pageload and navigation root spans. This is done centrally in `_createRouteSpan`, which every pageload and navigation span funnels through, so all downstream framework SDKs inherit these attributes without additional wiring. Co-Authored-By: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
3831498 to
2ad4840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds high-cardinality
url.pathandurl.fullattributes to pageload and navigation spans. We need them for span description inference in Relay: https://getsentry.github.io/sentry-conventions/descriptions/#browser-pageloadMore specific router instrumentations who can set a parameterized route will also set
url.templatewhich is the preferred attribute.ref #21921