feat: Set url.template on pageload and navigation spans across framework SDKs#21953
Draft
Lms24 wants to merge 3 commits into
Draft
feat: Set url.template on pageload and navigation spans across framework SDKs#21953Lms24 wants to merge 3 commits into
Lms24 wants to merge 3 commits into
Conversation
Lms24
requested review from
chargome,
mydea and
nicohrubec
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 02659b6. Configure here.
| if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') { | ||
| span.updateName(route); | ||
| span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route'); | ||
| span.setAttribute('url.template', route); |
There was a problem hiding this comment.
Missing tests for url.template
Medium Severity
This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 02659b6. Configure here.
| activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source); | ||
| if (source === 'route') { | ||
| activeRootSpan.setAttribute('url.template', name); | ||
| } |
There was a problem hiding this comment.
Stale url template on downgrade
Medium Severity
When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 02659b6. Configure here.
Contributor
size-limit report 📦
|
chargome
approved these changes
Jul 3, 2026
chargome
left a comment
chargome
left a comment
Member
There was a problem hiding this comment.
LGTM, but should we assert in tests?
Member
Author
yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft. |
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
5500d3b to
945194a
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
2 times, most recently
from
9152b09 to
a5997a6
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
088a93e to
7c4bfcb
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
2 times, most recently
from
b40658d to
7ea373e
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
d20b04f to
c20fc4a
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
7ea373e to
882142c
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
c20fc4a to
41cc9bd
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
2 times, most recently
from
14cbb12 to
cae6c25
Compare
Lms24
changed the base branch from
feat/pageload-url-attrs-base
to
feat/pageload-url-attrs-angular
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
2 times, most recently
from
ed08f20 to
d792a0e
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
from
9afa5d7 to
26d8b46
Compare
… SDKs Apply url.template to pageload and navigation root spans across Astro, Next.js, React, React Router, Remix, Solid, SvelteKit, and Vue integrations. Co-Authored-By: Cursor <cursoragent@cursor.com>
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
from
26d8b46 to
d7ce684
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
d792a0e to
66cf987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, most of this will be broken down into individual PRs
part of #21921