test(node): Migrate logging integration tests to create*Tests helpers#21955
Merged
Conversation
Move the winston, pino and consola node integration test suites onto the shared runner helpers, splitting each `subject.ts`/inline server into an `instrument.mjs` (Sentry.init) + `scenario.mjs` pair. - pino: `createEsmTests` (keeps its existing ESM-only coverage) - winston, consola: `createCjsTests` (keeps their existing CJS-only coverage) No coverage change vs. the previous per-suite run mode; each suite runs in the same module format it did before. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
requested review from
JPeer264 and
andreiborza
and removed request for
a team
andreiborza
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
winston,pinoandconsolanode integration test suites onto the shared runner helpers, splitting eachsubject.ts/inline server into aninstrument.mjs(Sentry.init) +scenario.mjspair.createEsmTests(keeps its existing ESM-only coverage; one call per scenario/instrument combo, dropping the manual.withInstrument()since the helper wires it via flags)createCjsTests(keeps its existing CJS-only coverage; env-var-driven behaviour preserved via.withEnv())createCjsTests(keeps its existing CJS-only coverage; one call per scenario sharing a single instrument)Each suite runs in the same module format it did before, so there is no coverage change — this only moves them onto the
create*Testspattern. All assertions are preserved verbatim.🤖 Generated with Claude Code