test(node): Migrate http client span tests to createCjsTests#21956
Merged
Conversation
Move the nine `tracing/http-client-spans/*` suites onto the shared
`createCjsTests` runner helper, splitting each inline `scenario.ts` into an
`instrument.mjs` (`Sentry.init`) + `scenario.mjs` pair. Each suite keeps its
own instrument config (tracesSampleRate, traceLifecycle, fetch/http
integration options, debug) and runs in CJS as before.
The `http-otel-double-instrumentation` suite now shares one `scenario.mjs`
between its two instruments (`instrument.mjs` with debug, and
`instrument-mitigation.mjs` with `httpIntegration({ spans: false })`), each of
which registers the OTel `HttpInstrumentation` to reproduce the
double-instrumentation case.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
requested review from
JPeer264 and
andreiborza
and removed request for
a team
andreiborza
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the nine
tracing/http-client-spans/*suites onto the sharedcreateCjsTestsrunner helper, splitting each inlinescenario.tsinto aninstrument.mjs(Sentry.init) +scenario.mjspair.Each suite keeps its own instrument config and runs in CJS, matching its previous run mode:
traceLifecycle: 'stream'nativeNodeFetchIntegrationrequest/response hooksnativeNodeFetchIntegrationheader mappingscenario.mjsacross two instruments (instrument.mjswithdebug: true, andinstrument-mitigation.mjswithhttpIntegration({ spans: false })), each registering the OTelHttpInstrumentationto reproduce and mitigate the double-span caseNo coverage change — every suite runs in the same (CJS) module format it did before, with assertions preserved verbatim.
🤖 Generated with Claude Code