Skip to content

ref(node): Refactor orchestrion config into separate files#21957

Merged
mydea merged 2 commits into
developfrom
fn/orchestrion-config-per-file
Jul 6, 2026
Merged

ref(node): Refactor orchestrion config into separate files#21957
mydea merged 2 commits into
developfrom
fn/orchestrion-config-per-file

Conversation

@mydea

@mydea mydea commented Jul 3, 2026

Copy link
Copy Markdown
Member

This PR just splits up the orchestrion config for instrumentation into a file per instrumentation, making it a bit cleaner and easier to follow.

This is on top of #21658

@mydea mydea self-assigned this Jul 3, 2026
Base automatically changed from fn/try-orchestrion to develop July 3, 2026 12:54
@mydea mydea force-pushed the fn/orchestrion-config-per-file branch from 1551956 to 4693d6c Compare July 3, 2026 13:02
@mydea mydea marked this pull request as ready for review July 3, 2026 13:03
@mydea mydea requested a review from a team as a code owner July 3, 2026 13:03
@mydea mydea requested review from JPeer264 and andreiborza and removed request for a team July 3, 2026 13:03
@mydea mydea force-pushed the fn/orchestrion-config-per-file branch from 4693d6c to 3adefaf Compare July 3, 2026 13:09

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3adefaf. Configure here.

Comment thread packages/server-utils/rollup.npm.config.mjs

@isaacs isaacs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clanker concern about file location breaking the submodule export is valid.

Once that's fixed, omg, yes, please get this landed ASAP, before we add more of these. It's so annoying to keep resolving those conflicts, this can't happen soon enough! 👏😅

...pgChannels,
...openaiChannels,
...anthropicAiChannels,
...vercelAiChannels,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES. 👏

Comment thread packages/server-utils/rollup.npm.config.mjs
@mydea mydea merged commit 14ed5f1 into develop Jul 6, 2026
388 of 390 checks passed
@mydea mydea deleted the fn/orchestrion-config-per-file branch July 6, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants