fix(react/solid/vue): Instrument TanStack Router navigations via onBeforeLoad/onResolved#21975
Merged
Merged
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7c4f5eb. Configure here.
chargome
requested review from
andreiborza,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
s1gr1d
approved these changes
Jul 6, 2026
| it('subscribes to router navigation events when instrumentNavigation is true', () => { | ||
| const integration = tanstackRouterBrowserTracingIntegration(mockRouter, { | ||
| instrumentNavigation: true, | ||
| instrumentPageLoad: false, |
Member
There was a problem hiding this comment.
Q: Why was this added here? The test still asserts only "when instrumentNavigation is true" (same in the test below)
Member
Author
There was a problem hiding this comment.
This was just added for testing the navigation events in isolation. This way it's cleaner and easier to test router.subscribe above.
andreiborza
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we only instrument navigations via
onBeforeNavigate. This hook is surpressed in TanStack after anyredirectwas thrown.This PR changes the mechanics to instrument via
onBeforeLoad/onResolved, both are unaffected by redirects. Verified this in E2E.Note that currently the integration is duplicated in the specific SDKs, while the code is almost identical. We can follow up by moving this into browser maybe, but out of scope for this PR
closes #21966