ref(server-utils): Add orchestrion support for Vercel AI v5#21979
Open
mydea wants to merge 3 commits into
Open
ref(server-utils): Add orchestrion support for Vercel AI v5#21979mydea wants to merge 3 commits into
mydea wants to merge 3 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d2d3306. Configure here.
| const parent = resolveModelCallParent(); | ||
| if (!parent || toolCallSpans.has(parent)) { | ||
| return original.apply(this, [input, ...rest]); | ||
| } |
There was a problem hiding this comment.
streamText v5 tools miss spans
Medium Severity
For Vercel AI v5 under orchestrion, patchToolExecute only opens a tool span when resolveModelCallParent() finds an active operation span. streamText is wired as a synchronous channel, so its invoke_agent span ends as soon as streamText returns, while tool execute runs later during stream consumption. The parent check then fails and tool calls are silently not traced.
Reviewed by Cursor Bugbot for commit d2d3306. Configure here.
Member
Author
There was a problem hiding this comment.
this behaves the same as in v5, things may be emitted weirdly but it's fine to keep consistency with v5 in otel I'd say here.
Contributor
size-limit report 📦
|
mydea
requested review from
JPeer264 and
andreiborza
and removed request for
a team
andreiborza
reviewed
Jul 7, 2026
Comment on lines
+23
to
+26
| ...vercelAiEntries('>=5.0.0 <6.0.0', 'generateText', 'generateText', 'Async'), | ||
| ...vercelAiEntries('>=5.0.0 <6.0.0', 'streamText', 'streamText', 'Sync'), | ||
| ...vercelAiEntries('>=5.0.0 <6.0.0', 'embed', 'embed', 'Async'), | ||
| ...vercelAiEntries('>=5.0.0 <6.0.0', 'embedMany', 'embedMany', 'Async'), |
Member
There was a problem hiding this comment.
q: Why don't we just adjust the ranges for these 4 apis?
Comment on lines
+434
to
+444
| // This runs inside the channel `start` transform (no upstream try/catch), so a throw here would break | ||
| // the user's `ai` call. Instrumentation must never do that — degrade to no tool span instead. | ||
| try { | ||
| for (const [toolName, tool] of Object.entries(tools)) { | ||
| if (isRecord(tool)) { | ||
| patchToolExecute(toolName, tool as PatchableTool, tools, options); | ||
| } | ||
| } | ||
| } catch { | ||
| DEBUG_BUILD && debug.log('Vercel AI orchestrion tool patching failed.'); | ||
| } |
Member
There was a problem hiding this comment.
m: Maybe we could move the try/catch inside the loop so we can continue patching tools even if earlier tools fail to patch for whatever reason, wdyt?
Or does one failure indicate we can never patch the other tools anyway?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds orchestrion support for Vercel AI v5 (v6 support already exists).