Skip to content

feat(server-utils): Migrate postgres.js instrumentation to orchestrion #21983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreiborza wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat(server-utils): Migrate postgres.js instrumentation to orchestrion #21983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0300e4a
feat(server-utils): Migrate postgres.js instrumentation to orchestrion
andreiborza Jul 6, 2026
2ab1349
Backfill connection attributes for the first query per connection via…
andreiborza Jul 6, 2026
c65871a
Extract postgres.js connection and query-span helpers into postgres-j…
andreiborza Jul 7, 2026
2e903c6
Move postgres.js integration into a folder and reuse core query/conne…
andreiborza Jul 7, 2026
bc2b480
Inline postgres.js integration back into a single file
andreiborza Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions dev-packages/node-integration-tests/suites/tracing/postgresjs/instrument-requestHook.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,32 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

const requestHook = (span, sanitizedSqlQuery, connectionContext) => {
// Add custom attributes to demonstrate requestHook functionality
span.setAttribute('custom.requestHook', 'called');

// Set context information as extras for test validation
Sentry.setExtra('requestHookCalled', {
sanitizedQuery: sanitizedSqlQuery,
database: connectionContext?.ATTR_DB_NAMESPACE,
host: connectionContext?.ATTR_SERVER_ADDRESS,
port: connectionContext?.ATTR_SERVER_PORT,
});
};

// Under orchestrion (INJECT_ORCHESTRION), `experimentalUseDiagnosticsChannelInjection()` has already run
// and the default `PostgresJs` OTel integration is swapped for the channel one. Passing the OTel
// `postgresJsIntegration()` explicitly here would override that swap and silently re-test the old path,
// so use the channel integration instead — configured with the same requestHook.
const postgresJsIntegration =
process.env.INJECT_ORCHESTRION === 'true'
? Sentry.diagnosticsChannelInjectionIntegrations().postgresJsIntegration({ requestHook })
: Sentry.postgresJsIntegration({ requestHook });

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
integrations: [
Sentry.postgresJsIntegration({
requestHook: (span, sanitizedSqlQuery, connectionContext) => {
// Add custom attributes to demonstrate requestHook functionality
span.setAttribute('custom.requestHook', 'called');

// Set context information as extras for test validation
Sentry.setExtra('requestHookCalled', {
sanitizedQuery: sanitizedSqlQuery,
database: connectionContext?.ATTR_DB_NAMESPACE,
host: connectionContext?.ATTR_SERVER_ADDRESS,
port: connectionContext?.ATTR_SERVER_PORT,
});
},
}),
],
integrations: [postgresJsIntegration],
});
Loading
Loading