Skip to content

test(node): Update vercel AI v7 version in tests & skip on Node 18 #21984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 2 commits into from
Jul 8, 2026
Merged

test(node): Update vercel AI v7 version in tests & skip on Node 18 #21984

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a62374
skip v7 tests on node 18
mydea Jul 6, 2026
69ef616
cleanup
mydea Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 67 additions & 83 deletions dev-packages/node-integration-tests/suites/tracing/vercelai/v6_v7/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,20 @@ import {
import { cleanupChildProcesses, createEsmAndCjsTests, createEsmTests } from '../../../../utils/runner';
import { isOrchestrionEnabled } from '../../../../utils';

describe.each([
['6', '^6.0.0'],
['7', '7.0.0-beta.179'],
])('Vercel AI integration (version %s)', (version, vercelAiVersion) => {
// On Node 18, we only test v6 as v7 is not supported
const matrix =
NODE_VERSION.major === 18
? ([['6', '^6.0.0']] as const)
: ([
['6', '^6.0.0'],
['7', '^7.0.0'],
] as const);

describe.each(matrix)('Vercel AI integration (version %s)', (version, vercelAiVersion) => {
afterAll(() => {
cleanupChildProcesses();
});

// Vercel AI v7 does not support CJS
// This fails on Node 18 only, as newer versions of ESM support require
const nodeVersion = NODE_VERSION.major;
const failsOnCjs = version === '7' && nodeVersion === 18;

const usesChannels = version === '7' || isOrchestrionEnabled();

// in v7 and orchestrion mode, we use the channel-based integration
Expand Down Expand Up @@ -167,7 +168,6 @@ describe.each([
additionalDependencies: {
ai: vercelAiVersion,
},
failsOnCjs,
Comment thread
cursor[bot] marked this conversation as resolved.
},
);

Expand Down Expand Up @@ -530,45 +530,37 @@ describe.each([
// A single model instance shared by two concurrent `streamText` calls carries only one
// captured-parent slot, so both model calls must still land under their own `invoke_agent` — not
// collapse onto whichever operation resolved the shared model last.
// `ai` v7 publishes the top-level `streamText`/`step` channel events through a code path that
// loads `node:diagnostics_channel` via `process.getBuiltinModule()`, which was only added in
// Node 20.16 / 22.3 and never backported to Node 18. On Node 18 that lookup returns undefined,
// so the `streamText` event is never published and no `invoke_agent` span is created. The
// non-streaming ops load the channel via dynamic `import()` and are unaffected.
test.skipIf(version === '7' && nodeVersion === 18)(
'parents concurrent streamText calls that share one model instance correctly',
async () => {
await createRunner()
.expect({ transaction: { transaction: 'main' } })
.expect({
span: container => {
const invokeAgents = container.items.filter(
span => span.attributes?.['sentry.op']?.value === 'gen_ai.invoke_agent',
);
const generateContents = container.items.filter(
span => span.attributes?.['sentry.op']?.value === 'gen_ai.generate_content',
);

// Two concurrent operations -> two invoke_agent + two generate_content spans.
expect(invokeAgents).toHaveLength(2);
expect(generateContents).toHaveLength(2);

const agentSpanIds = new Set(invokeAgents.map(span => span.span_id));

// Each model call lands under an invoke_agent span...
for (const span of generateContents) {
expect(agentSpanIds.has(span.parent_span_id!)).toBe(true);
}
// ...a distinct one each (no cross-attribution despite the shared model instance)...
expect(new Set(generateContents.map(span => span.parent_span_id)).size).toBe(2);
// ...and both operations sit under the same `main` parent.
expect(new Set(invokeAgents.map(span => span.parent_span_id)).size).toBe(1);
},
})
.start()
.completed();
},
);
test('parents concurrent streamText calls that share one model instance correctly', async () => {
await createRunner()
.expect({ transaction: { transaction: 'main' } })
.expect({
span: container => {
const invokeAgents = container.items.filter(
span => span.attributes?.['sentry.op']?.value === 'gen_ai.invoke_agent',
);
const generateContents = container.items.filter(
span => span.attributes?.['sentry.op']?.value === 'gen_ai.generate_content',
);

// Two concurrent operations -> two invoke_agent + two generate_content spans.
expect(invokeAgents).toHaveLength(2);
expect(generateContents).toHaveLength(2);

const agentSpanIds = new Set(invokeAgents.map(span => span.span_id));

// Each model call lands under an invoke_agent span...
for (const span of generateContents) {
expect(agentSpanIds.has(span.parent_span_id!)).toBe(true);
}
// ...a distinct one each (no cross-attribution despite the shared model instance)...
expect(new Set(generateContents.map(span => span.parent_span_id)).size).toBe(2);
// ...and both operations sit under the same `main` parent.
expect(new Set(invokeAgents.map(span => span.parent_span_id)).size).toBe(1);
},
})
.start()
.completed();
});
},
{
additionalDependencies: {
Expand All @@ -582,40 +574,32 @@ describe.each([
'scenario-stream-text.mjs',
'instrument.mjs',
(createRunner, test) => {
// `ai` v7 publishes the top-level `streamText`/`step` channel events through a code path that
// loads `node:diagnostics_channel` via `process.getBuiltinModule()`, which was only added in
// Node 20.16 / 22.3 and never backported to Node 18. On Node 18 that lookup returns undefined,
// so the `streamText` event is never published and no `invoke_agent` span is created. The
// non-streaming ops load the channel via dynamic `import()` and are unaffected.
test.skipIf(version === '7' && nodeVersion === 18)(
'creates streamText spans with the model call parented to invoke_agent',
async () => {
await createRunner()
.expect({ transaction: { transaction: 'main' } })
.expect({
span: container => {
// Every emitted gen_ai span carries the version-appropriate origin.
container.items
.filter(s => String(s.attributes?.['sentry.op']?.value ?? '').startsWith('gen_ai.'))
.forEach(s => expect(s.attributes?.['sentry.origin']?.value).toBe(expectedOrigin));
const invokeAgent = container.items.find(
span => span.attributes?.['sentry.op']?.value === 'gen_ai.invoke_agent',
)!;
expect(invokeAgent).toBeDefined();
expect(invokeAgent.attributes?.['vercel.ai.operationId']?.value).toBe('ai.streamText');

const generateContent = container.items.find(
span => span.attributes?.['sentry.op']?.value === 'gen_ai.generate_content',
)!;
expect(generateContent).toBeDefined();
expect(generateContent.parent_span_id).toBe(invokeAgent.span_id);
expect(generateContent.attributes?.['vercel.ai.operationId']?.value).toBe('ai.streamText.doStream');
},
})
.start()
.completed();
},
);
test('creates streamText spans with the model call parented to invoke_agent', async () => {
await createRunner()
.expect({ transaction: { transaction: 'main' } })
.expect({
span: container => {
// Every emitted gen_ai span carries the version-appropriate origin.
container.items
.filter(s => String(s.attributes?.['sentry.op']?.value ?? '').startsWith('gen_ai.'))
.forEach(s => expect(s.attributes?.['sentry.origin']?.value).toBe(expectedOrigin));
const invokeAgent = container.items.find(
span => span.attributes?.['sentry.op']?.value === 'gen_ai.invoke_agent',
)!;
expect(invokeAgent).toBeDefined();
expect(invokeAgent.attributes?.['vercel.ai.operationId']?.value).toBe('ai.streamText');

const generateContent = container.items.find(
span => span.attributes?.['sentry.op']?.value === 'gen_ai.generate_content',
)!;
expect(generateContent).toBeDefined();
expect(generateContent.parent_span_id).toBe(invokeAgent.span_id);
expect(generateContent.attributes?.['vercel.ai.operationId']?.value).toBe('ai.streamText.doStream');
},
})
.start()
.completed();
});
},
{
additionalDependencies: {
Expand Down
Loading