test(e2e): Add Astro 7 with Orchestrion test#22005
Conversation
s1gr1d
requested review from
a team,
chargome,
isaacs,
mydea and
nicohrubec
and removed request for
a team
isaacs
left a comment
isaacs
left a comment
There was a problem hiding this comment.
Note about yet another "leaking the o-word into user code", but I actually think it's the correct move at this stage. These can serve as a todo list later, when we are polishing up and consolidating more of the browser bundler parts of orchestrion with the rest of our bundler machinery.
LGTM, though, good comprehensive test of bundling and server-instrumentation together. 👍
| vite: { | ||
| // Run the orchestrion code transform on the Vite SSR bundle so instrumented | ||
| // DB drivers get `diagnostics_channel` publishers injected at build time. | ||
| plugins: [sentryOrchestrionPlugin()], |
There was a problem hiding this comment.
TODO: I think it makes sense to keep using the internal bundler bits in e2e tests at this stage, but at some point we need to do a git grep -i orchestrion dev-packages/e2e-tests/test-applications and make sure that our public-facing bundler API can handle all the use cases, and make the tests not "cheat" by using the internal machinery. Similar discussions I saw around using orchestrion+vite for cloudflare. (cc: @timfish, @JPeer264)
2 participants
Adds E2E test app with Orchestrion Vite plugin.
Closes #21997
Linear: https://linear.app/getsentry/issue/JS-2940/add-e2e-test-app-for-orchestrion-instrumentations-on-astro