test: Avoid unnecessary definedness checks for attributes on SerializedStreamedSpan objects #22060
Merged
mydea merged 3 commits intoJul 8, 2026
Conversation
Lms24
changed the title
attributes on SerializedStreamedSpan objects
mydea
approved these changes
Jul 8, 2026
Lms24
requested review from
JPeer264,
andreiborza and
logaretm
and removed request for
a team
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Jul 8, 2026
mydea
force-pushed
the
test/node-integration-suite-type-check
branch
from
2e57e43 to
3ceac73
Compare
Now that attributes is required on SerializedStreamedSpan, remove unnecessary attributes?. checks in streamed span tests and helpers. Co-Authored-By: Cursor <cursoragent@cursor.com>
Co-Authored-By: Cursor <cursoragent@cursor.com>
mydea
force-pushed
the
test/serialized-streamed-span-attributes-tests
branch
from
9aff545 to
7131b28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts tests to avoid checking for definedness on
SerializedStreamedSpanattributes(following #22052)