ref(core): Use common span attribute keys from Sentry conventions#22081
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
requested review from
JPeer264,
andreiborza,
logaretm and
mydea
and removed request for
a team
andreiborza
approved these changes
Jul 8, 2026
Member
Author
|
size impact seems mostly favourable (or within margins of minimal flakes). Gonna merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates a few of our attribute key exports, in favour of the same attribute keys in
@sentry/conventions. Replaces all usage of the attributes across the codebase.Decided to give this a go on some very infrequently used attributes first, to check bundle size impact and work required for such migrations.