ref(angular): Streamline url attribute creation#22091
Merged
Merged
Conversation
Lms24
requested review from
chargome,
mydea and
s1gr1d
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit aca4884. Configure here.
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
aca4884 to
6b38616
Compare
Lms24
changed the title
url attribute creation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
from
a518d21 to
1d77c34
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
6b38616 to
8bd50da
Compare
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
8bd50da to
ff5adcc
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
from
1d77c34 to
6c98bbb
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
ff5adcc to
be1c420
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
from
6c98bbb to
6190c45
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
be1c420 to
ff5adcc
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
2 times, most recently
from
6c98bbb to
6190c45
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
2 times, most recently
from
be1c420 to
ff5adcc
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
from
6190c45 to
6c98bbb
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
ff5adcc to
a40f18b
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
from
6c98bbb to
8d16900
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
a40f18b to
6265a7c
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
from
8d16900 to
3aea408
Compare
logaretm
approved these changes
Jul 8, 2026
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
ffde4cb to
c2ee1fa
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
2 times, most recently
from
eed2188 to
cc1771f
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
c2ee1fa to
a020c02
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
from
cc1771f to
c62961f
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
2 times, most recently
from
acde345 to
a698c2c
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
2 times, most recently
from
f476dfc to
cfa4176
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
a698c2c to
9a2444e
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
from
cfa4176 to
ef79aed
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
9a2444e to
ae419a9
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
from
ef79aed to
a8ecb5c
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
2 times, most recently
from
584269b to
cb61d0b
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-solid
branch
2 times, most recently
from
92e0d28 to
cf15b60
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
cb61d0b to
a0eea1a
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
a0eea1a to
e018d44
Compare
…ributes Refactors Angular routing to use the shared getAbsoluteUrl helper for url.full and url.path on pageload and navigation spans. part of #21921 Co-Authored-By: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24
force-pushed
the
feat/pageload-url-attrs-frameworks
branch
from
e018d44 to
9d41e7a
Compare
Lms24
added a commit
that referenced
this pull request
Jul 9, 2026
…22095) Emit `url.template`, `url.path`, and `url.full` on Ember pageload and navigation root spans so Ember aligns with the other framework router instrumentations in this stack. Navigation spans set URL attributes at `routeDidChange` via `routerService.currentURL`, once the destination route is finalized. Dynamic path segments are parameterized into `url.template` (e.g. `/users/123` → `/users/:user_id`). E2E coverage was added for both `ember-classic` and `ember-embroider`, plus unit tests for the URL attribute helpers. Stacked on #22091. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the
getAbsoluteUrlhelper introduced in #22006 to streamline the url attribute creation pipeline and loose some bytes in the process.part of #21921