Skip to content

feat(scope): dont use hub for capturing events anymore#2132

Open
Litarnus wants to merge 1 commit into
core-state-swapfrom
capture-on-scope
Open

feat(scope): dont use hub for capturing events anymore#2132
Litarnus wants to merge 1 commit into
core-state-swapfrom
capture-on-scope

Conversation

@Litarnus

Copy link
Copy Markdown
Contributor

Extracts logic into BreadcrumbRecorder and EventCatcher and replaces usage in functions.php to no longer use the Hub.

Comment thread src/functions.php
Comment on lines +13 to +14
use Sentry\State\BreadcrumbRecorder;
use Sentry\State\EventCapturer;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capturer is awkward in my head maybe EventRecorder is a nice fit. But highly subjective so feel free to leave as is!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes more sense, we have BreadcrumbRecorder and SpanRecorder so that would fit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants