feat(asgi): Migrate away from event processor in span first#5920
feat(asgi): Migrate away from event processor in span first#5920sentrivana wants to merge 3 commits intomasterfrom
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
1 similar comment
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.70s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 6.12%. Project has 14732 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 25.26% 30.02% +4.76%
==========================================
Files 189 189 —
Lines 21007 21053 +46
Branches 6862 6886 +24
==========================================
+ Hits 5306 6321 +1015
- Misses 15701 14732 -969
- Partials 432 477 +45Generated by Codecov Action |
Description
In span first, there are no event processors. Therefore, we need to be able to set the data we were setting in event processors in some other way.
As we migrate our integrations one by one, this will be an exercise in whether it's possible to achieve this without some sort of callback/lifecycle hooks. So far, in ASGI, it seems we can get by by simply using
scope.set_attribute()for setting request related data, and updating the segment name/source just before the span ends.Adding this enables us to actually test the new functionality.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)