feat(asgi): Gate client IP/user info behind data_collection config#6841
Open
ericapisani wants to merge 3 commits into
Open
feat(asgi): Gate client IP/user info behind data_collection config#6841ericapisani wants to merge 3 commits into
ericapisani wants to merge 3 commits into
Conversation
Apply data_collection.user_info filtering to REMOTE_ADDR/client.address, falling back to send_default_pii when data_collection is not configured. Also convert earlier query parameter data collection tests to end-to-end assertions via a real ASGI app. Ref PY-2586 Ref #6746
Contributor
Codecov Results 📊✅ 94263 passed | ⏭️ 6338 skipped | Total: 100601 | Pass Rate: 93.7% | Execution Time: 325m 37s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2506 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.68% 89.65% -0.03%
==========================================
Files 193 193 —
Lines 24007 24218 +211
Branches 8342 8504 +162
==========================================
+ Hits 21530 21712 +182
- Misses 2477 2506 +29
- Partials 1386 1396 +10Generated by Codecov Action |
ericapisani
marked this pull request as ready for review
July 20, 2026 15:27
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8c9f43d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Apply data_collection.user_info filtering to REMOTE_ADDR/client.address,
falling back to send_default_pii when data_collection is not configured.
Also convert earlier query parameter data collection tests to end-to-end assertions via a real ASGI app.
Ref PY-2586
Ref #6746