chore: Migrate from ESLint to oxlint #5867
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| // See http://go.microsoft.com/fwlink/?LinkId=827846 | ||
| // for the documentation about the extensions.json format | ||
| "recommendations": ["esbenp.prettier-vscode", "nickelpack.oxlint"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| { | ||
| "$schema": "./node_modules/oxlint/configuration_schema.json", | ||
| "plugins": ["typescript", "react", "import", "jsdoc"], | ||
| "jsPlugins": [ | ||
| { | ||
| "name": "sdk", | ||
| "specifier": "@sentry-internal/eslint-plugin-sdk" | ||
| } | ||
| ], | ||
| "categories": {}, | ||
| "rules": { | ||
| "no-unused-vars": [ | ||
| "warn", | ||
| { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_", "caughtErrorsIgnorePattern": "^_" } | ||
| ], | ||
|
|
||
| // === Base rules (ported from @sentry-internal/eslint-config-sdk) === | ||
| "no-console": "error", | ||
| "no-alert": "error", | ||
| "no-param-reassign": "error", | ||
| "prefer-template": "error", | ||
| "no-bitwise": "error", | ||
| "complexity": "error", | ||
| "no-unused-expressions": ["error", { "allowShortCircuit": true }], | ||
| "guard-for-in": "error", | ||
| "array-callback-return": ["error", { "allowImplicit": true }], | ||
| "quotes": ["error", "single", { "avoidEscape": true }], | ||
| "no-return-await": "error", | ||
| "max-lines": ["error", { "max": 300, "skipComments": true, "skipBlankLines": true }], | ||
|
|
||
| // === Import rules === | ||
| "import/namespace": "off", | ||
| "import/no-unresolved": "off", | ||
|
|
||
| // === Rules turned off (not needed or causing false positives) === | ||
| "no-control-regex": "off", | ||
| "jsdoc/check-tag-names": "off", | ||
| "jsdoc/require-yields": "off", | ||
| "no-shadow": "off", | ||
| "no-unsafe-optional-chaining": "off", | ||
| // Not in original ESLint config — auto-enabled by --type-aware, produces false positives on mocked functions | ||
| "typescript/await-thenable": "off", | ||
|
|
||
| // === Custom SDK rules (via JS plugin) === | ||
| "sdk/no-eq-empty": "error" | ||
| }, | ||
| "overrides": [ | ||
| { | ||
| "files": ["**/*.ts", "**/*.tsx", "**/*.d.ts"], | ||
| "rules": { | ||
| "typescript/ban-ts-comment": "error", | ||
| "typescript/consistent-type-imports": "error", | ||
| "typescript/no-unnecessary-type-assertion": "error", | ||
| "typescript/prefer-for-of": "error", | ||
| "typescript/explicit-function-return-type": ["error", { "allowExpressions": true }], | ||
| "typescript/no-floating-promises": ["error", { "ignoreVoid": false }], | ||
| "typescript/no-dynamic-delete": "error", | ||
| "typescript/unified-signatures": "error", | ||
| "typescript/no-unsafe-member-access": "error", | ||
| "typescript/unbound-method": "error", | ||
| "typescript/no-explicit-any": "warn", | ||
| "typescript/no-empty-function": "off", | ||
| "typescript/no-empty-object-type": "off", | ||
| "typescript/no-require-imports": "off", | ||
| "typescript/prefer-optional-chain": "error", | ||
| "typescript/no-unused-vars": ["error", { "argsIgnorePattern": "^_", "caughtErrors": "none" }], | ||
| "typescript/no-redundant-type-constituents": "off", | ||
| "typescript/restrict-template-expressions": "off", | ||
| "typescript/no-base-to-string": "off" | ||
| } | ||
| }, | ||
| { | ||
| "files": ["**/*.js", "**/*.mjs", "**/*.cjs"], | ||
| "rules": { | ||
| "typescript/ban-ts-comment": "off", | ||
| "typescript/consistent-type-imports": "off", | ||
| "typescript/prefer-optional-chain": "off", | ||
| "typescript/no-unnecessary-type-assertion": "off", | ||
| "typescript/prefer-for-of": "off", | ||
| "typescript/no-floating-promises": "off", | ||
| "typescript/no-dynamic-delete": "off", | ||
| "typescript/no-unsafe-member-access": "off", | ||
| "typescript/unbound-method": "off", | ||
| "typescript/no-explicit-any": "off", | ||
| "typescript/explicit-function-return-type": "off" | ||
| } | ||
| }, | ||
| { | ||
| "files": [ | ||
| "**/*.test.ts", | ||
| "**/*.test.tsx", | ||
| "**/*.test.js", | ||
| "**/*.test.jsx", | ||
| "test/**/*.ts", | ||
| "test/**/*.js" | ||
| ], | ||
| "rules": { | ||
| "typescript/explicit-function-return-type": "off", | ||
| "typescript/no-empty-function": "off", | ||
| "typescript/no-explicit-any": "off", | ||
| "typescript/no-unsafe-member-access": "off", | ||
| "typescript/no-floating-promises": "off", | ||
| "typescript/no-non-null-assertion": "off", | ||
| "typescript/unbound-method": "off", | ||
| "no-unused-expressions": "off", | ||
| "typescript/no-unused-expressions": "off", | ||
| "max-lines": "off", | ||
| "complexity": "off", | ||
| "import/first": "off", | ||
| "typescript/prefer-optional-chain": "off", | ||
| "typescript/no-misused-spread": "off", | ||
| "sdk/no-focused-tests": "error", | ||
| "sdk/no-skipped-tests": "error" | ||
| } | ||
| }, | ||
| { | ||
| "files": ["*.tsx"], | ||
| "rules": { | ||
| "jsdoc/require-jsdoc": "off" | ||
| } | ||
| }, | ||
| { | ||
| "files": ["scripts/*"], | ||
| "rules": { | ||
| "no-console": "off" | ||
| } | ||
| }, | ||
| { | ||
| "files": ["**/src/**"], | ||
| "rules": { | ||
| "no-restricted-globals": ["error", "window", "document", "location", "navigator"], | ||
| // Bundle size isn't a concern for React Native | ||
| "sdk/no-class-field-initializers": "off", | ||
| // TODO: Re-enable once oxlint supports inline disable for jsPlugin rules | ||
| // Only 2 intentional uses exist (debugsymbolicator.ts, sentryMetroSerializer.ts) | ||
| "sdk/no-regexp-constructor": "off" | ||
| } | ||
| } | ||
| ], | ||
| "ignorePatterns": [ | ||
| "dist/**", | ||
| "dangerfile.js", | ||
| "RNSentryAndroidTester/**", | ||
| "test/react-native/versions/**", | ||
| "coverage/**", | ||
| "test/typescript/**", | ||
| "metro.d.ts", | ||
| "plugin/build/**", | ||
| "expo.d.ts", | ||
| "playground.js", | ||
| "playground.d.ts", | ||
| "node_modules/**" | ||
| ] | ||
| } | ||
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.