fix(ci): Avoid unnecessary runner allocation by splitting platform matrix into separate jobs#5924
Merged
fix(ci): Avoid unnecessary runner allocation by splitting platform matrix into separate jobs#5924
Conversation
…trix into separate jobs
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
Plus 1 more 🤖 This preview updates automatically when you update the PR. |
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Avoid unnecessary runner allocation by splitting platform matrix into separate jobs ([#5924](https://github.com/getsentry/sentry-react-native/pull/5924))If none of the above apply, you can opt out of this check by adding |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: macOS build logs upload path points to wrong directory
- Updated the macOS upload-artifact path to
samples/react-native-macos/macos/*.logsoxcodebuild.logfrom the build directory is uploaded.
- Updated the macOS upload-artifact path to
Or push these changes by commenting:
@cursor push 0a35387757
Preview (0a35387757)
diff --git a/.github/workflows/sample-application.yml b/.github/workflows/sample-application.yml
--- a/.github/workflows/sample-application.yml
+++ b/.github/workflows/sample-application.yml
@@ -305,7 +305,7 @@
uses: actions/upload-artifact@v7
with:
name: build-sample-legacy-macos-${{ matrix.build-type }}-no-frameworks-logs
- path: ${{ env.REACT_NATIVE_SAMPLE_PATH }}/macos/*.log
+ path: samples/react-native-macos/macos/*.log
test-ios:
name: Test ios production REV2This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
antonis
reviewed
Mar 30, 2026
antonis
reviewed
Mar 30, 2026
antonis
reviewed
Mar 30, 2026
antonis
reviewed
Mar 30, 2026
antonis
reviewed
Mar 30, 2026
antonis
reviewed
Mar 30, 2026
antonis
reviewed
Mar 30, 2026
antonis
reviewed
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes #5864
Updates runners in
sample-application.yamlandsample-application-expo.yamlto not allocate any runners when the job is skipped. It also eliminates any need inplatform-check— skip logic now moved to job-level if. The main benefit is cost savings — when a platform is skipped (e.g., a PR only touches Android native code), the iOS and web jobs won't allocate runners at all. The functional behavior is identical to how it was before.📝 Checklist
sendDefaultPIIis enabled